Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added convenience methods plan.options() and plan.hosts() #132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

manuelbieh
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 98.833% when pulling e7e88b4 on manuelbieh:master into b6be5c1 on pstadler:master.

@manuelbieh
Copy link
Author

Should be options() instead of option() maybe

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 98.45% when pulling e9eead7 on manuelbieh:master into b6be5c1 on pstadler:master.

@manuelbieh manuelbieh changed the title added convenience methods plan.option() and plan.hosts() added convenience methods plan.options() and plan.hosts() Apr 19, 2016
* @method options(key)
*/
Flightplan.prototype.options = function(key) {
if(typeof key === 'undefined') {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace with !key.

@pstadler
Copy link
Owner

Thanks for your contribution. Could you write tests for it? Check https://github.com/pstadler/flightplan/blob/master/test/test.flightplan.js

@pstadler
Copy link
Owner

pstadler commented Oct 6, 2016

Do you want to continue here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants